chore(round)!: Change Round.IgnoredPlayers to use Player#760
Open
Unbistrackted wants to merge 2 commits intoExMod-Team:devfrom
Open
chore(round)!: Change Round.IgnoredPlayers to use Player#760Unbistrackted wants to merge 2 commits intoExMod-Team:devfrom
Round.IgnoredPlayers to use Player#760Unbistrackted wants to merge 2 commits intoExMod-Team:devfrom
Conversation
Author
|
The only thing I'm curious is to why IgnoredPlayers has only a size of 20, I didn't changed since there might be a reason to it |
size of a List it's only a pregenerate memory you can add more than 20 player in it it's just than the list will not have the memory already available for it |
louis1706
approved these changes
Feb 25, 2026
Someone-193
approved these changes
Mar 1, 2026
Someone-193
left a comment
Someone-193
left a comment
There was a problem hiding this comment.
good PR, wrong target branch though @louis1706, dont forget that when you merge this to Exiled 10
Author
|
@Someone-193 changed the target branch, forgot abt changing it when i created the pr sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
Round.IgnoredPlayersusingPlayerWhat is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Round.IgnoredPlayershashset will be usingPlayerinstead ofReferenceHubOther information:
Wanted to do this cause it's simple copy and paste in the IL side
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other